This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Fixed next button not working when maxVisible=1 bug #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #30
Furthermore, I felt a bit confused about the leap implementation. For example,
$('.demo').bootpag({
total: 27,
page: 16,
maxVisible: 10,
leaps: true
});
when I click the prev button,it goes to page 10——which is absolutely right, while it goes to page 17 instead of page 21 when I click the next button because the page is less than (total - maxVisible).It may confuse the user.So, I modified the leap implementation so that it will go to next(/previous) set of pages once the user click the next(/previous) button as long as it is legal.