Fix Field3D::setBoundaryTo for FCI methods #3030
Open
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, boundary conditions set on yup/down fields are not applied when a boundary is copied from one field to another.
dschwoerer
requested changes
Nov 22, 2024
src/field/field3d.cxx
Outdated
| // Interpolate midpoint value in f3d | ||
| const BoutReal val = pnt.interpolate_sheath_o1(f3d); | ||
| // Set the same boundary value in this field | ||
| pnt.dirichlet_o2(*this, val); |
There was a problem hiding this comment.
We should either take o2 twice, or o1 twice:
Suggested change
| pnt.dirichlet_o2(*this, val); | |
| pnt.dirichlet_o1(*this, val); |
I think o1 should be sufficient, as f3d and *this should be close. But I am not sure what is more stable ...
There was a problem hiding this comment.
The FA code also uses first order, so I have pushed a fixed based on that ...
src/field/field3d.cxx
Outdated
| pnt.dirichlet_o2(*this, val); | ||
| } | ||
| } | ||
| return; |
There was a problem hiding this comment.
For hermes that might work, but should we not also copy the x-boundary conditions with FCI?
Suggested change
| return; |
|
@bendudson Are you ok with these changes? |
|
I just noticed #2962 is also open - is the other still needed with this one? |
bendudson
commented
Nov 26, 2024
There was a problem hiding this comment.
Thanks @dschwoerer ! The changes look good to me.
I think #2962 is not needed once this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, boundary conditions set on yup/down fields are not applied when a boundary is copied from one field to another.
@dschwoerer This is needed in Hermes-3 with FCI so that this line correctly applies the sheath boundary conditions to the density field:
https://github.com/bendudson/hermes-3/blob/master/src/evolve_density.cxx#L217