Fix issues with parsing and emitting EDN characters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is the parser was assuming that what follows the backslash is an atom (I presume like a symbol) but characters like parens should be allowed here when they're not in atoms. Added some customized logic for reading chars, not particularly optimized but I don't think it's a big bottleneck. Added some basic tests.
When emitting regular printable characters, the backslash escape character was being left out.
|
@skyrod-vactai Hi - can you clarify what issues this is solving? |
|
nevermind - i see the linked issues. Can you fix the failing lints? |
|
Thanks for looking at this @bowbahdoe ! I fixed the 2 lint errors that I caused. The other ones appear to be in the existing code. The coverage error, I am not sure what that's about, it doesn't appear to be caused by my PR either: |
|
@skyrod-vactai I published a new version. |
|
Thanks! Will upgrade and try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4, #5. All the tests pass (including a few extra asserts I added), so hopefully it's not breaking anything.