feat(metadata-sidebar): remove empty update function

box · Sep 24, 2024 · e2a1f23 · e2a1f23
1 parent bf84a54
commit e2a1f23
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/src/elements/content-sidebar/MetadataSidebarRedesign.tsx b/src/elements/content-sidebar/MetadataSidebarRedesign.tsx
@@ -79,7 +79,6 @@ function MetadataSidebarRedesign({
         errorMessage,
         status,
         templateInstances,
-        updateMetadataInstance,
     } = useSidebarMetadataFetcher(api, fileId, onError, isFeatureEnabled);
 
     const { formatMessage } = useIntl();
@@ -115,9 +114,8 @@ function MetadataSidebarRedesign({
     };
 
     const handleSubmit = async (values: FormValues) => {
-        isExistingMetadataInstance()
-            ? updateMetadataInstance()
-            : handleCreateMetadataInstance(values.metadata as MetadataTemplateInstance, () => setEditingTemplate(null));
+        !isExistingMetadataInstance() &&
+            handleCreateMetadataInstance(values.metadata as MetadataTemplateInstance, () => setEditingTemplate(null));
     };
 
     const metadataDropdown = status === STATUS.SUCCESS && templates && (

diff --git a/src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx b/src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx
@@ -76,7 +76,6 @@ describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => {
             errorMessage: null,
             status: STATUS.SUCCESS,
             file: mockFile,
-            updateMetadataInstance: jest.fn(),
         });
     });
 
@@ -124,7 +123,6 @@ describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => {
             },
             status: STATUS.ERROR,
             file: mockFile,
-            updateMetadataInstance: jest.fn(),
         });
 
         const errorMessage = { id: 'error', defaultMessage: 'error message' };
@@ -143,7 +141,6 @@ describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => {
             errorMessage: null,
             status: STATUS.LOADING,
             file: mockFile,
-            updateMetadataInstance: jest.fn(),
         });
 
         renderComponent();
@@ -180,7 +177,6 @@ describe('elements/content-sidebar/Metadata/MetadataSidebarRedesign', () => {
             status: STATUS.SUCCESS,
             file: mockFile,
             handleCreateMetadataInstance: jest.fn(),
-            updateMetadataInstance: jest.fn(),
         });
 
         renderComponent();

diff --git a/src/elements/content-sidebar/hooks/useSidebarMetadataFetcher.ts b/src/elements/content-sidebar/hooks/useSidebarMetadataFetcher.ts
@@ -26,7 +26,6 @@ interface DataFetcher {
     status: STATUS;
     templateInstances: Array<MetadataTemplateInstance>;
     templates: Array<MetadataTemplate>;
-    updateMetadataInstance: () => void;
 }
 
 function useSidebarMetadataFetcher(
@@ -147,10 +146,6 @@ function useSidebarMetadataFetcher(
         [api, onApiError, file, deleteMetadataInstanceSuccessCallback],
     );
 
-    const updateMetadataInstance = () => {
-        // to be implemented in the next ticket
-    };
-
     const handleCreateMetadataInstance = React.useCallback(
         (templateInstance: MetadataTemplateInstance, successCallback): void => {
             api.getMetadataAPI(false).createMetadataRedesign(
@@ -182,7 +177,6 @@ function useSidebarMetadataFetcher(
         status,
         templateInstances,
         templates,
-        updateMetadataInstance,
     };
 }