Bulk merge CLI updates from ehoogerbeets/mojito #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3) This way, it is much more easily scripted
Prevent empty drop creation when locales are specified
Reimplemented logic in test helper method CLITestBase#waitForRepositoryToHaveStringsForTranslations to decouple it from DropExportCommand#shouldCreateDrop. This is done to avoid CommandException thrown by shouldCreateDrop which can occur when the DropExportCommand is given locales that do not exist in a given repository. Helper method is only supposed to check if any string in any of the translatable locales of a repository is awaiting translation (i.e. what the shouldCreateDrop checks when no locales are specified). The logic is not changed here. This is based on fix c28eabc.
wadimw
force-pushed
the
cli-updates-cleanup
branch
from
6feed1b to
f5908a5
Compare
Given a repository in which only some (but not all) locales are fully translated, when drop export is triggered specifying only locales which are fully translated, drop should not be created (because it would be empty). This is a test for fix 88f3b06.
wadimw
added
the
legacy
wadimw
force-pushed
the
cli-updates-cleanup
branch
from
5739fce to
e5ac9ae
Compare
Closed
Add commands to cancel a drop or mark it as complete
Add quiet mode for drop-export command
Add drop-view command
wadimw
force-pushed
the
cli-updates-cleanup
branch
from
7ebd01b to
7160496
Compare
wadimw
changed the title
ehoogerbeets
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied changes from @ehoogerbeets fork with CLI updates, cleaned them up and added some tests.
--drop-idCLI parameter todrop-importcommand (6d6fb56)drop-cancelanddrop-closecommands (bf355c2)--quietCLI switch to switch to minimal output (fd67a69)drop-viewcommand to list info about available drops (7160496)