Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set web3 version to latest stable #8

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

begonaalvarezd
Copy link
Member

Looks like this is a dependency issue. The dependency we have in this project for svelte web3 needs to add web3 using a CDN which was pointing to latest. Suprise surprise, some days ago web3 released a major version moving from 1.x.y to 4.x.y :trollface:
This PR aims to set the web3 version to the latest known stable version, checked in web.archive.org.
Please note that, as of now, the native tokens never resolve, it seems like the IF is doing some maintainance work in the EVM, for if that happens, you can comment out pollNativeTokens for testing purposes

⚠️ This is just a temporary solution, until the dependencies we use fix their problems with the new version of web3. Would be nice opening an issue to https://github.com/clbrge/svelte-web3 explaining the situation.

Close #7

Copy link

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
image

@begonaalvarezd begonaalvarezd merged commit 4fc02f0 into main Jun 20, 2023
@begonaalvarezd begonaalvarezd deleted the fix/web3-dependency branch June 20, 2023 10:02
@begonaalvarezd begonaalvarezd restored the fix/web3-dependency branch June 20, 2023 10:02
@begonaalvarezd begonaalvarezd deleted the fix/web3-dependency branch April 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix metamask connection error
2 participants