Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add architecture diagram #147

Conversation

CastaChick
Copy link
Contributor

ref: #144

README.md Outdated
@@ -52,6 +52,10 @@ Supports both fenced markdown (see screenshots), and mmd files.

<img src="https://raw.githubusercontent.com/bpruitt-goddard/vscode-mermaid-syntax-highlight/master/images/quadrantChart.png" alt="Quadrant Chart Screenshot" width="325">

### Architecture Diagram

<img src="https://raw.githubusercontent.com/castachick/vscode-mermaid-syntax-highlight/master/images/architecture.png" alt="Architecture Diagram Screenshot" width="500">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can this up be updated to pull from this repo?

@bpruitt-goddard
Copy link
Owner

If we want to bump the version and deploy with this PR merge, can you add two extra changes? I would bump the minor version to 1.7.0 as I've been increasing minor with changes like new diagram types.

  1. Bump the version in package.json
  2. Add the new version to the top of the changelog
    • Note There is a copy/paste error in the last update so the most recent line should really be 1.6.7 and this change should be 1.7.0.

@CastaChick CastaChick force-pushed the feat/add_architecture_diagram branch from 4901822 to a25023a Compare November 6, 2024 01:04
@CastaChick
Copy link
Contributor Author

CastaChick commented Nov 6, 2024

@bpruitt-goddard Thank you for your review. I've bumped the version to v1.7.0.

@koshea
Copy link
Contributor

koshea commented Nov 6, 2024

I tested this as well, works great, thank you.

@bpruitt-goddard bpruitt-goddard merged commit 37e987e into bpruitt-goddard:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants