-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Additional Field Settings and Added IP Address Support #8
base: master
Are you sure you want to change the base?
Conversation
Added support to provide additional parameters for Additional and Extra fields.
Updated README.md for changes in Additoinal and Extrad Fields Settings.
Added support for ip address.
Hi! The part about the the additional fields can be done, but line 116 must be
instead of
to avoid incompatibility with exiting implementations. This means if As for the More generally, the column types used by monolog-wordpress can become something customized in Regarding your changes to log the IP addresses, that is certainly not something all users would need or like, and it's not reasonable to force such specific behaviour onto others. For the very same reason our talented friends at Monolog have designed the architecture of the logging stack in a way, that anyone can implement their own 'automatically add some custom data to my log entries' needs. The solution is called Processors. You should implement a custom processor that adds the IP address as an extra field, and push that Processor to your PS: it may be better to submit unrelated features as separate PRs, so they can be discussed and approved independently. |
Added support to provide additional parameters for Additional and Extra fields. With this user can provide extra details for each field. So, extra fields can be more flexible.
Added support to store IP address with log.