This repository has been archived by the owner on May 15, 2023. It is now read-only.
Simplify API, clarify documentation, reduce repetition #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify API: Hide the construction of fetch_function from the user Clarify documentation, and make metadata in example a dict for clarity Switch quantized_fuzzer example from raw to all logit, it seems faster Reformat nan_fuzzer to use new Fuzzer API
DoctorTeeth
reviewed
Sep 18, 2018
| @@ -49,6 +47,10 @@ | |||
| FLAGS = tf.flags.FLAGS | |||
|
|
|||
|
|
|||
| if FLAGS.checkpoint_dir is None: | |||
There was a problem hiding this comment.
Something weird happens to me when this line runs.
I get an error from absl telling me that alsologtostderr is not a recognized FLAG.
It seems totally unrelated but when I comment out this check everything works fine?
Would you just remove this check for now?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify API: Hide the construction of fetch_function from the user
Clarify documentation, and make metadata in example a dict for clarity
Switch quantized_fuzzer example from raw to all logit, it seems faster
Reformat nan_fuzzer to use new Fuzzer API