Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding models from timm lib #1696

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Adding models from timm lib #1696

merged 2 commits into from
Jan 14, 2025

Conversation

akgokce
Copy link
Contributor

@akgokce akgokce commented Jan 13, 2025

Add models from the timm library with region-specific commitments to the repository.

@KartikP
Copy link
Collaborator

KartikP commented Jan 14, 2025

Hi @akgokce! Is this ready for review and then merge or are you planning to add to this still?

@akgokce
Copy link
Contributor Author

akgokce commented Jan 14, 2025

Hi @KartikP! This version is ready for review. While we plan to add more in the future, this pull request includes the pre-selected models for now.

KartikP
KartikP approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@KartikP KartikP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I appreciate the readability of all of the files.

Missing test.py but nbd

@KartikP KartikP merged commit 918ebc1 into brain-score:master Jan 14, 2025
12 of 13 checks passed
@akgokce
Copy link
Contributor Author

akgokce commented Jan 14, 2025

Thank you! Could you please let me know where I can view the benchmark results?

@KartikP
Copy link
Collaborator

KartikP commented Jan 14, 2025 •
edited
Loading

You can view the current progress here: http://www.brain-score-jenkins.com:8080/job/dev_score_plugins/255/consoleFull

You've submitted ~20 models, so this might take a while. Should be viewable on the leaderboard by tomorrow morning.

UPDATE: Reran scoring to reduce cloudwatch log query interval. New link: http://www.brain-score-jenkins.com:8080/job/dev_score_plugins/259/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KartikP KartikP KartikP approved these changes

Assignees
No one assigned
Labels
mapping-complete trigger-mapping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akgokce @KartikP