Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove print from detached HEAD #30

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

brainelectronics
Copy link
Owner

Using the branch property of HistoryWalker in collector.py would print HEAD is detached: ... in case the HEAD is detached during a pull request build. This could lead to errors while creating a changelog with --dry-run and passing the output to a supposed JSON file, being finally unable to parse it as with that detached HEAD output it's not a JSON anymore.

@brainelectronics brainelectronics added the bug Something isn't working label Oct 12, 2024
@brainelectronics brainelectronics self-assigned this Oct 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (3369d04) to head (ad27898).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           1        1           
  Lines          36       36           
  Branches        8        8           
=======================================
  Hits           30       30           
  Misses          4        4           
  Partials        2        2           
Flag Coverage Δ
unittests 83.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@brainelectronics brainelectronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMyself

@brainelectronics brainelectronics merged commit 1d39e73 into main Oct 12, 2024
6 checks passed
@brainelectronics brainelectronics deleted the bugfix/remove-print-in-detached-HEAD branch October 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants