Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in line with #143 #144

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Nov 7, 2023

Closes #143.

Adds explicit dependencies and removes outdated dependencies.

  • brainglobe-napari-io is needed, but never imported. See Adam's comment here.
  • pytables is needed as a pandas extra, so we now depend on pandas[hdf5] which will fetch pytables.
  • dask has been removed as a dependency.
  • napari-plugin-engine has been removed as a dependency.
  • scipy, bg-atlasapi, tifffile, qtpy, have been added as explicit dependencies.

Once merged we should tag v1.0.1 so that the team over on conda-forge also receive the update.

@adamltyson
Copy link
Member

@willGraham01 willGraham01 marked this pull request as ready for review November 7, 2023 10:58
@willGraham01 willGraham01 requested a review from a team November 7, 2023 10:58
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willGraham01

@adamltyson adamltyson merged commit ed16aba into main Nov 7, 2023
10 of 11 checks passed
@adamltyson adamltyson deleted the update-dependencies branch November 7, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
2 participants