Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header from brainglobe-utils #172

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add header from brainglobe-utils #172

merged 3 commits into from
Apr 22, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Apr 12, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently, the brainglobe-segmentation widget has no header (i.e. no brainglobe logo / documentation links...).

What does this PR do?
This PR adds a header from brainglobe-utils:
Screenshot 2024-04-12 115632

References

For brainglobe/cellfinder#327

How has this PR been tested?

All tests pass locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech K-Meech requested a review from a team April 12, 2024 14:59
@K-Meech
Copy link
Contributor Author

K-Meech commented Apr 12, 2024

The macos failure seems to be something to do with PyTables, and version 3.9.2

@adamltyson adamltyson merged commit d46749a into main Apr 22, 2024
11 checks passed
@adamltyson adamltyson deleted the headers branch April 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants