Include stacktrace context in messages for caught exceptions from LLM functions & function callbacks. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions and function callbacks. - caught exceptions were logging their type and message, however, without a stack trace or location for the exception debugging may be required to locate some issues. - added format_exception/3 to LangChain.LangChainError to format exceptions with context from the stacktrace. The third argument is the format - :short only includes the location and the default gives a full stack trace at the end of the message. - I updated the most obvious places where a lack of context could slow down fixing issues, however there are other rescue blocks where this may be useful.
|
Very nice! I love this. Thanks! I appreciate the updated test coverage too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In upgrading some code to 0.3.0 I had a few exceptions to track down and found the lack of context in the caught error messages slowed things down.
This change adds context to the error messages logged and kept in the chain for LLM functions and function callbacks. I took an initial stab at the places this seems most valuable while avoiding putting full stack traces in the chain.
The details: