Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for multi-class margin loss #566

Merged
merged 1 commit into from
Dec 27, 2023
Merged

add support for multi-class margin loss #566

merged 1 commit into from
Dec 27, 2023

Conversation

charlielam0615
Copy link
Collaborator

@charlielam0615 charlielam0615 commented Dec 26, 2023 •
edited by chaoming0625
Loading

add support for multi-class margin loss

Description

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which updates documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe here):

Checklist

  • Code follows the code style of this project.
  • Changes follow the CONTRIBUTING guidelines.
  • Update necessary documentation accordingly.
  • Lint and tests pass locally with the changes.
  • Check issues and pull requests first. You don't want to duplicate effort.

Other information

@charlielam0615
add support for multi-class margin loss
68da27e 
add support for multi-class margin loss
@charlielam0615 charlielam0615 self-assigned this Dec 26, 2023
@charlielam0615 charlielam0615 mentioned this pull request Dec 26, 2023
Closed
2 tasks
chaoming0625
chaoming0625 reviewed Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

The test errors may be caused by the incorrect macOS wheel. I have re-runned all failed tests to see whether it can be fixed.

chaoming0625
chaoming0625 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have been all passed. Great work.

@chaoming0625 chaoming0625 merged commit fb9a321 into brainpy:master Dec 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoming0625 chaoming0625 chaoming0625 approved these changes

Assignees

@charlielam0615 charlielam0615

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlielam0615 @chaoming0625