Cleanup

braintree · Oct 31, 2023 · 039571a · 039571a
1 parent 7ce4a97
commit 039571a
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 75 deletions.
diff --git a/Demo/src/main/java/com/braintreepayments/demo/SEPADirectDebitFragment.java b/Demo/src/main/java/com/braintreepayments/demo/SEPADirectDebitFragment.java
@@ -7,22 +7,17 @@
 import android.widget.Button;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 import androidx.navigation.fragment.NavHostFragment;
 
 import com.braintreepayments.api.BraintreeClient;
 import com.braintreepayments.api.PostalAddress;
 import com.braintreepayments.api.SEPADirectDebitBrowserSwitchResult;
-import com.braintreepayments.api.SEPADirectDebitBrowserSwitchResultCallback;
 import com.braintreepayments.api.SEPADirectDebitClient;
-import com.braintreepayments.api.SEPADirectDebitFlowStartedCallback;
 import com.braintreepayments.api.SEPADirectDebitLauncher;
 import com.braintreepayments.api.SEPADirectDebitLauncherCallback;
-import com.braintreepayments.api.SEPADirectDebitListener;
 import com.braintreepayments.api.SEPADirectDebitMandateType;
 import com.braintreepayments.api.SEPADirectDebitNonce;
 import com.braintreepayments.api.SEPADirectDebitRequest;
-import com.braintreepayments.api.SEPADirectDebitResponse;
 
 import java.util.UUID;
 

diff --git a/...rectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitBrowserSwitchResult.java b/...rectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitBrowserSwitchResult.java
@@ -1,6 +1,11 @@
 package com.braintreepayments.api;
 
-// TODO: - Docstring
+/**
+ * Result received from the SEPA mandate web flow through {@link SEPADirectDebitBrowserSwitchResultCallback}.
+ * This result should be passed to
+ * {@link SEPADirectDebitClient#onBrowserSwitchResult(SEPADirectDebitBrowserSwitchResult, SEPADirectDebitBrowserSwitchResultCallback)} )}
+ * to complete the SEPA mandate flow.
+ */
 public class SEPADirectDebitBrowserSwitchResult {
 
     private BrowserSwitchResult browserSwitchResult;
@@ -21,4 +26,4 @@ BrowserSwitchResult getBrowserSwitchResult() {
     Exception getError() {
         return error;
     }
-}
+}
diff --git a/...t/src/main/java/com/braintreepayments/api/SEPADirectDebitBrowserSwitchResultCallback.java b/...t/src/main/java/com/braintreepayments/api/SEPADirectDebitBrowserSwitchResultCallback.java
@@ -10,7 +10,7 @@ public interface SEPADirectDebitBrowserSwitchResultCallback {
 
     /**
      * @param sepaDirectDebitNonce {@link SEPADirectDebitNonce}
-     * @param error              an exception that occurred while processing a PayPal result
+     * @param error                an exception that occurred while processing a PayPal result
      */
     void onResult(@Nullable SEPADirectDebitNonce sepaDirectDebitNonce, @Nullable Exception error);
 }
diff --git a/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitClient.java b/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitClient.java
@@ -65,7 +65,8 @@ public void tokenize(@NonNull final FragmentActivity activity,
                             braintreeClient.sendAnalyticsEvent(
                                     "sepa-direct-debit.create-mandate.success");
                             try {
-                                SEPADirectDebitResponse sepaDirectDebitResponse = new SEPADirectDebitResponse(buildBrowserSwitchOptions(result), null);
+                                SEPADirectDebitResponse sepaDirectDebitResponse =
+                                        new SEPADirectDebitResponse(buildBrowserSwitchOptions(result), null);
                                 callback.onResult(sepaDirectDebitResponse, null);
                             } catch (JSONException exception) {
                                 braintreeClient.sendAnalyticsEvent(
@@ -85,7 +86,8 @@ public void tokenize(@NonNull final FragmentActivity activity,
                                         if (sepaDirectDebitNonce != null) {
                                             braintreeClient.sendAnalyticsEvent(
                                                     "sepa-direct-debit.tokenize.success");
-                                            SEPADirectDebitResponse sepaDirectDebitResponse = new SEPADirectDebitResponse(null, sepaDirectDebitNonce);
+                                            SEPADirectDebitResponse sepaDirectDebitResponse =
+                                                    new SEPADirectDebitResponse(null, sepaDirectDebitNonce);
                                             callback.onResult(sepaDirectDebitResponse, null);
                                         } else if (tokenizeError != null) {
                                             braintreeClient.sendAnalyticsEvent(

diff --git a/...DirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitLifecycleObserver.java b/...DirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitLifecycleObserver.java
diff --git a/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitListener.java b/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitListener.java
diff --git a/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitResponse.java b/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitResponse.java
@@ -2,6 +2,14 @@
 
 import androidx.fragment.app.FragmentActivity;
 
+/**
+ * Returned via the {@link SEPADirectDebitFlowStartedCallback} after calling 
+ * {@link SEPADirectDebitClient#tokenize(FragmentActivity, SEPADirectDebitRequest, SEPADirectDebitFlowStartedCallback)}.
+ *
+ * Inspect the {@link SEPADirectDebitNonce} property to determine if tokenization is complete, or
+ * if you must continue the SEPA mandate web flow via
+ * {@link SEPADirectDebitLauncher#launch(FragmentActivity, SEPADirectDebitResponse)}
+ */
 public class SEPADirectDebitResponse {
 
     private BrowserSwitchOptions browserSwitchOptions;

diff --git a/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitTokenizeCallback.java b/SEPADirectDebit/src/main/java/com/braintreepayments/api/SEPADirectDebitTokenizeCallback.java
@@ -5,5 +5,4 @@
 interface SEPADirectDebitTokenizeCallback {
 
     void onResult(@Nullable SEPADirectDebitNonce sepaDirectDebitNonce, @Nullable Exception error);
-
 }
diff --git a/v5_MIGRATION_GUIDE.md b/v5_MIGRATION_GUIDE.md
@@ -397,7 +397,6 @@ class MyActivity : FragmentActivity() {
 +           intent)
     }
 
-
     fun initializeClients() {
         braintreClient = BraintreeClient(context, "TOKENIZATION_KEY_OR_CLIENT_TOKEN")
 -       sepaDirectDebitClient = SEPADirectDebitClient(this, braintreeClient)