Add SdkComponent and move configuration fetch out of BraintreeClient #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that require context to a SdkComponent singleton
saperi22
approved these changes
Nov 12, 2024
tdchow
commented
Nov 13, 2024
| integration | ||
| ) | ||
| fun sendEvent(event: AnalyticsEvent) { | ||
| configurationLoader.loadConfiguration { result -> |
There was a problem hiding this comment.
Added the fetching of Configuration here
tdchow
changed the title
…nt and ConfigurationLoader
jaxdesmarais
approved these changes
Nov 14, 2024
| * Returns the instance of [SdkComponent] | ||
| */ | ||
| fun getInstance(): SdkComponent { | ||
| return checkNotNull(instance) |
There was a problem hiding this comment.
If this ever is null what happens at that point?
There was a problem hiding this comment.
It would throw an IllegalStateException. However this should never happen since create() would be called before getInstance(), which would set the singleton instance.
saperi22
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ConfigurationLoaderResultto make it easier to handleConfigurationLoaderCallback.onResult()AnalyticsClientChecklist
Authors