Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APP_LINK_SETUP.md #1213

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update APP_LINK_SETUP.md #1213

merged 1 commit into from
Nov 15, 2024

Conversation

saperi22
Copy link
Contributor

Summary of changes

  • Update APP_LINK_SETUP.md

Checklist

  • Added a changelog entry
  • Relevant test coverage

Authors

List GitHub usernames for everyone who contributed to this pull request.

@saperi22, @richherrera

@saperi22 saperi22 requested a review from a team as a code owner November 15, 2024 14:49
Copy link
Collaborator

@tdchow tdchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used these steps in the v5 dev doc updates. Do we need to update those steps as well?

@saperi22
Copy link
Contributor Author

@tdchow When Rich and I were testing yesterday, these were the options shown. We were on sandbox.
Unless we know of any sandbox/production differences in the website, I think we'd want to update the other set of docs too, to be consistent and up to date.

@saperi22 saperi22 merged commit 8add877 into main Nov 15, 2024
3 checks passed
@saperi22 saperi22 deleted the update-app-link-setup2 branch November 15, 2024 15:20
@tdchow
Copy link
Collaborator

tdchow commented Nov 15, 2024

@tdchow When Rich and I were testing yesterday, these were the options shown. We were on sandbox. Unless we know of any sandbox/production differences in the website, I think we'd want to update the other set of docs too, to be consistent and up to date.

Sounds good! I'll open a PR updating the v5 docs with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants