Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXO fix url response data sent inside native checkout client #765

Merged
merged 5 commits into from
Aug 17, 2023
Merged

NXO fix url response data sent inside native checkout client #765

merged 5 commits into from
Aug 17, 2023

Conversation

kelay858
Copy link
Contributor

@kelay858 kelay858 commented Aug 7, 2023 •
edited
Loading

Thank you for your contribution to Braintree.

Before submitting this PR, note that we cannot accept language translation PRs. We support the same languages that are supported by PayPal, and have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

  • Changing the payment method response json to put the correct url to send back in
  • Setting the correctUrlResponseData on the account inside the native client

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@kelay858 kelay858 requested a review from a team as a code owner August 7, 2023 21:33
@kelay858 kelay858 changed the title Nxo fallback fix NXO fix url response data sent inside payload Aug 7, 2023
@kelay858 kelay858 changed the title NXO fix url response data sent inside payload NXO fix url response data sent inside native checkout client Aug 7, 2023
jaxdesmarais
jaxdesmarais reviewed Aug 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kelay858
Copy link
Contributor Author

kelay858 commented Aug 9, 2023

cant merge until we pull in the latest native release

jaxdesmarais
jaxdesmarais reviewed Aug 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kelay858 @jaxdesmarais
Update CHANGELOG.md
83c9eec 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@kelay858 kelay858 mentioned this pull request Aug 10, 2023
Closed
1 task
@sshropshire sshropshire merged commit 88c173b into master Aug 17, 2023
@sshropshire sshropshire deleted the nxo-fallback-fix branch August 17, 2023 14:22
sshropshire added a commit that referenced this pull request Aug 17, 2023
@sshropshire
Revert "NXO fix url response data sent inside native checkout client (#…
10def4b 
…765)"

This reverts commit 88c173b.
@sshropshire sshropshire mentioned this pull request Aug 17, 2023
Merged
1 task
sshropshire added a commit that referenced this pull request Aug 17, 2023
@sshropshire
Revert "NXO fix url response data sent inside native checkout client (#…
434a6f4 
…765)" (#769)

This reverts commit 88c173b.
@kelay858 kelay858 restored the nxo-fallback-fix branch August 21, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelay858 @jaxdesmarais @sshropshire