Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lint and CI Updates #792

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Add Lint and CI Updates #792

merged 5 commits into from
Oct 2, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Add gradle lint to CI (detekt to be added in future PR with required fixes)
  • Prepare to update master to main
  • Add integration test and lint tasks to ci file to be runnable via simple command line commands (I don't see a ton of value in adding the entire GitHub actions release process to the ci file but please note if it all should be added)
  • Remove legacy Rakefile

Checklist

  • [ ] Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner September 29, 2023 19:06
scannillo
scannillo approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@sarahkoop sarahkoop merged commit e45e655 into master Oct 2, 2023
tdchow added a commit that referenced this pull request Oct 18, 2023
@tdchow
Merge branch 'main' into auth-email-config
f57f048 
* main:
  Prepare for development
  Release 4.39.0
  Fix Publish and Release CI (#804)
  Update release.yml (#803)
  GooglePay Credit Card Disabled Fix (#801)
  Remove Preferred Payment Methods (#795)
  Add Detekt Linting (#793)
  YOLO - republish GitHub Pages
  Add Lint and CI Updates (#792)
  Update README.md (#790)
  Update to use Gradle Nexus Publish Plugin (#788)

# Conflicts:
#	CHANGELOG.md
@jaxdesmarais jaxdesmarais deleted the ci_updates branch August 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @jaxdesmarais @scannillo