Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Detekt Linting #793

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Add Detekt Linting #793

merged 9 commits into from
Oct 3, 2023

Conversation

sarahkoop
Copy link
Contributor

@sarahkoop sarahkoop commented Oct 3, 2023 •
edited
Loading

Summary of changes

  • Add detekt for Kotlin linting
  • Fix lint errors or suppress warnings for each issue (I attempted to resolve issues that didn't require actual logic/code changes and suppressed most of the "SwallowedException" errors that would require logic changes to keep this PR simple and to be resolved in the future)

Checklist

  • [ ] Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner October 3, 2023 16:56
jaxdesmarais
jaxdesmarais approved these changes Oct 3, 2023
View reviewed changes
BraintreeCore/src/main/java/com/braintreepayments/api/AnalyticsClient.kt
@@ -131,6 +137,7 @@ internal class AnalyticsClient @VisibleForTesting constructor(
} catch (e: Exception) {
ListenableWorker.Result.failure()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or does this look weird with two } at the same level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes the indentation was messed up here - fixed!

@sarahkoop sarahkoop merged commit b3c6445 into main Oct 3, 2023
2 checks passed
tdchow added a commit that referenced this pull request Oct 18, 2023
@tdchow
Merge branch 'main' into auth-email-config
f57f048 
* main:
  Prepare for development
  Release 4.39.0
  Fix Publish and Release CI (#804)
  Update release.yml (#803)
  GooglePay Credit Card Disabled Fix (#801)
  Remove Preferred Payment Methods (#795)
  Add Detekt Linting (#793)
  YOLO - republish GitHub Pages
  Add Lint and CI Updates (#792)
  Update README.md (#790)
  Update to use Gradle Nexus Publish Plugin (#788)

# Conflicts:
#	CHANGELOG.md
@jaxdesmarais jaxdesmarais deleted the add_detekt branch August 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @jaxdesmarais @sshropshire