Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Preferred Payment Methods #795

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Remove Preferred Payment Methods #795

merged 8 commits into from
Oct 4, 2023

Conversation

sarahkoop
Copy link
Contributor

@sarahkoop sarahkoop commented Oct 4, 2023 •
edited
Loading

Summary of changes

  • Remove Preferred Payment Methods from BraintreeCore and demo app
  • Open Question: should this change go on v5 or main? Our docs say this feature is beta so could remove in v4 instead

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner October 4, 2023 15:14
scannillo
scannillo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@scannillo scannillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I would remove it in V4

@sarahkoop
Revert "Merge branch 'v5' into remove_pref_payments"
d507ed5 
This reverts commit d96afaf, reversing
changes made to ab6e287.
@sarahkoop sarahkoop changed the base branch from v5 to main October 4, 2023 18:38
@sarahkoop sarahkoop merged commit d7e67f8 into main Oct 4, 2023
2 checks passed
@sarahkoop sarahkoop deleted the remove_pref_payments branch October 4, 2023 18:48
tdchow added a commit that referenced this pull request Oct 18, 2023
@tdchow
Merge branch 'main' into auth-email-config
f57f048 
* main:
  Prepare for development
  Release 4.39.0
  Fix Publish and Release CI (#804)
  Update release.yml (#803)
  GooglePay Credit Card Disabled Fix (#801)
  Remove Preferred Payment Methods (#795)
  Add Detekt Linting (#793)
  YOLO - republish GitHub Pages
  Add Lint and CI Updates (#792)
  Update README.md (#790)
  Update to use Gradle Nexus Publish Plugin (#788)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@scannillo scannillo scannillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @scannillo @sshropshire