3DS Launcher API #808
Merged
3DS Launcher API #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
reviewed
Oct 18, 2023
Demo/src/main/java/com/braintreepayments/demo/CardFragment.java
Outdated
Show resolved
Hide resolved
sshropshire
reviewed
Oct 18, 2023
ThreeDSecure/src/main/java/com/braintreepayments/api/CardinalResult.java
Show resolved
Hide resolved
sshropshire
reviewed
Oct 18, 2023
|
|
||
| public interface CardinalResultCallback { | ||
|
|
||
| void onCardinalResult(@NonNull CardinalResult cardinalResult); |
There was a problem hiding this comment.
Oh wait nevermind, I see now.
sshropshire
reviewed
Oct 18, 2023
| public ThreeDSecureClient(@NonNull BraintreeClient braintreeClient) { | ||
| this(null, null, braintreeClient, new CardinalClient(), | ||
| this(braintreeClient, new CardinalClient(), |
|
This is somewhat off topic, but I always found it odd that ThreeDSecureInfo.java is located in the |
We have a ticket to create a |
Co-authored-by: sshropshire <[email protected]>
jaxdesmarais
approved these changes
Oct 23, 2023
|
|
||
| import androidx.annotation.NonNull; | ||
|
|
||
| public interface CardinalResultCallback { |
There was a problem hiding this comment.
Does this callback need a docstring?
Co-authored-by: Jax DesMarais-Leder <[email protected]>
…tree_android into 3ds_launcher_api
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
performVerificationandcontinuePerformVerificationwith the addition of theThreeDSecureLauncherthe determination of whether to "continue" with the verification happens before launching nowCardinalpublic naming convention will not stay - just kept the name of the existing class made public for now)Checklist
Authors