SEPA Launcher API [Tests] #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DebitLauncher.java
…EPADirectDebitClient away from Listener
…e in SEPADemo Fragment
…ds from SEPAClient
…d; update demo fragment to use lambdas
…nt in demo fragment for clarity
…nt.tokenize(), add docstring
sarahkoop
reviewed
Nov 1, 2023
| verify(listener).onSEPADirectDebitSuccess(nonce); | ||
| verify(braintreeClient).sendAnalyticsEvent("sepa-direct-debit.tokenize.success"); | ||
| sut.tokenize(sepaDirectDebitRequest, (sepaDirectDebitResponse, error) -> { | ||
| assertEquals(sepaDirectDebitResponse.getNonce(), nonce); |
There was a problem hiding this comment.
Just confirming - are these callback assertions being invoked? I haven't seen this done without a countdown latch before
There was a problem hiding this comment.
Yes, these are! (Confirmed with breakpoints & making sure the tests failed when modified)
However I pushed a commit (a1b0434) to move these tests away from the callback syntax and to instead use ArgumentCaptor, to match with the standard way in this test file.
There was a problem hiding this comment.
Oh cool we maybe should move to that pattern eventually - seems cleaner. But good to go with the current pattern for now for consistency 👍
sarahkoop
reviewed
Nov 2, 2023
| } | ||
|
|
||
| // Save for SEPABrowserSwitchResult_Tests |
There was a problem hiding this comment.
Should this be in separate file?
sarahkoop
approved these changes
Nov 3, 2023
Base automatically changed from
sepa-launcher-api
to
sepa-launcer-api-refactor
November 6, 2023 15:00
sshropshire
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Added a changelog entryAuthors
@scannillo