Rename Google Pay APIs #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Nov 9, 2023
sshropshire
reviewed
Nov 9, 2023
| @@ -200,63 +189,55 @@ public void requestPayment(@NonNull final GooglePayRequest request, | |||
|
|
|||
| //noinspection ConstantConditions | |||
| if (request == null) { | |||
| callback.onGooglePayIntentData(null, new BraintreeException( | |||
There was a problem hiding this comment.
Random 🤔 : There may be a benefit to having on<PAYMENT_METHOD>Result() style callbacks. It would help in the extreme case that a merchant decides to implement multiple payment method listener interfaces on the same class. If they're all named the same it could get confusing. It's more verbose, but for single response objects they'll be shortened to lambdas on Java 8 and up.
There was a problem hiding this comment.
Good point - I'll plan to refactor the naming of these methods in the PRs that move to single result object callbacks to make sure that the naming all makes sense.
jaxdesmarais
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
createPaymentAuthRequestandtokenizeand rename associated result objects and callbacksChecklist
Authors