Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract HTTP client logic to HttpClient and JavaHttpClient. Make Http… #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

githubmicrob
Copy link

@githubmicrob githubmicrob commented Nov 15, 2024

…Client configurable.

Summary

Extracted HTTP client functionality to separate class. Introduced HttpClient interface to make the implementation of HTTP client replaceable. In our case having another implementation is necessary because Java implementation doesn't work with HTTPS proxies.

Checklist

  • [ x ] Added changelog entry
  • [ x ] Ran unit tests (rake test:unit)
  • I alphabetized all attributes, parameters, and methods by name in any class file I changed
  • I have linked the JIRA ticket in the summary section
  • I have reviewed the JIRA ticket to ensure all AC's are met
  • [ x ] I understand that unless this is a Draft PR or has a DO NOT MERGE label, this PR is considered to be in a deploy ready state and can be deployed if merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant