-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major version bump #59
base: main
Are you sure you want to change the base?
Conversation
…r be used as the entry point
Question for the team: We've talked about potentially deprecating support for Internet Explorer. Given that we have 4 modules testing for different versions, should we:
|
I think we can leave them as-is since someone else might be able to find those useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge in main and resolve the conflicts? Also, how close is this draft PR to being ready for review?
JIRA
Summary
/src
directory.index.ts
file as the entry point to the library. This is a breaking change, and the import statements to use our modules will now change:import { isChrome, isSafari } from @braintree/browser-detection
dist
directory directly from the source code.Why Vitest
Vitest is a "blazingly fast" unit test framework, and allows us to leave the test suite running in a watch-mode environment while we continue to make changes to our code. Only the necessary tests will re-run depending on what files were changed, making it much quicker to make changes without having to wait for the entire test suite to re-run.
Vitest has also been designed with a Jest compatible API, in order to make the migration from Jest as simple as possible. The API is essentially the same as Jest with some very minor differences.
Why Create
index.ts
as the entry pointdist
folder from the source codeChecklist
Authors