Main into v3 #103
Merged
Main into v3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saperi22
reviewed
Jun 3, 2024
| //import com.braintreepayments.api.BrowserSwitchOptions; | ||
| //import com.braintreepayments.api.BrowserSwitchResult; | ||
| // | ||
| //public class DemoActivity extends AppCompatActivity { |
There was a problem hiding this comment.
yep 😅 just removed it.
jaxdesmarais
reviewed
Jun 3, 2024
CHANGELOG.md
Outdated
Comment on lines
7
to
17
| * Bump `minSdkVersion` to API 23 | ||
| * Bump target Java version to Java 11 | ||
| * Upgrade Kotlin version to 1.9.10 | ||
| * Upgrade to Android Gradle Plugin 8 | ||
| * Change `BrowserSwitchClient#start` parameters and return type | ||
| * Change `BrowserSwitchClient#parseResult` parameters | ||
| * Remove `deliverResult`, `getResult`, `captureResult`, `clearActiveRequests`, `getResultFromCache`, and `deliverResultFromCache` from `BrowserSwitchClient` | ||
| * Add `BrowserSwitchRequest` and `BrowserSwitchPendingRequest` | ||
| * Convert `BrowserSwitchResult` to sealed class and add `BrowserSwitchResultInfo` | ||
| * Remove `BrowserSwitchStatus` | ||
| * Rename `parseResult()` to `completeRequest()` |
There was a problem hiding this comment.
Looks like these are bumped in a little too far now
| } | ||
|
|
||
|
|
||
| // TODO: FIX THIS |
There was a problem hiding this comment.
I assume this should still be commented out?
There was a problem hiding this comment.
i ended up fixing the test case 👍
sarahkoop
approved these changes
Jun 3, 2024
sshropshire
approved these changes
Jun 4, 2024
jaxdesmarais
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors