[V3] Rename BrowserSwitchStartResult .Success to .Started
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
commented
Jul 1, 2024
| @@ -10,6 +10,7 @@ class PendingRequestStore { | |||
| private const val SHARED_PREFS_KEY = "PENDING_REQUESTS" | |||
| private const val PENDING_REQUEST_KEY = "BROWSER_SWITCH_REQUEST" | |||
|
|
|||
| @JvmStatic | |||
There was a problem hiding this comment.
general cleanup to make static methods more Java friendly.
sarahkoop
approved these changes
Jul 1, 2024
tdchow
approved these changes
Jul 1, 2024
tdchow
added a commit
that referenced
this pull request
Jul 8, 2024
* v3: (21 commits) [V3] Rename BrowserSwitchStartResult `.Success` to `.Started` (#105) V3 encode pending browser switch as base64 string (#104) Fix changelog indents and fix app link unit test Pass app link in BrowserSwitchPendingRequestUnitTest Remove DemoActivity Fix Compose flow and move app link intent filter to DemoActivitySingleTop Merge main into v3 Rename parseResult to completeRequest (#101) Revert version to beta1 (#100) Visibility Changes for BT Venmo Module (#99) Update BrowserSwitchException and BrowserSwitchRequest Visibility Modifiers (#91) Update Gradle Release Tasks for Beta (#89) Convert `BrowserSwitchResult` to Sealed Class (#88) v3 Migration Guide (#87) Fix Javadocs Task for SNAPSHOT Publish (#86) Upgrade Gradle Dependencies (#85) Remove v2 Integration Pattern Methods (#84) Update Demo App for v3 Integration (#82) Add Convenience String Methods to BrowserSwitchPendingRequest (#83) Add Integration Pattern without Local Storage (#81) ... # Conflicts: # CHANGELOG.md # README.md # browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchClient.java # browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchRequest.java # browser-switch/src/test/java/com/braintreepayments/api/BrowserSwitchClientUnitTest.java # browser-switch/src/test/java/com/braintreepayments/api/BrowserSwitchRequestUnitTest.java # browser-switch/src/test/java/com/braintreepayments/api/BrowserSwitchResultUnitTest.java # build.gradle # demo/src/main/AndroidManifest.xml # demo/src/main/java/com/braintreepayments/api/browserswitch/demo/DemoActivity.java # demo/src/main/java/com/braintreepayments/api/browserswitch/demo/DemoActivitySingleTop.java # demo/src/main/java/com/braintreepayments/api/browserswitch/demo/DemoFragment.java # demo/src/main/res/values/strings.xml # gradle/gradle-publish.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BrowserSwitchStartResult.SuccesstoBrowserSwitchStartResult.StartedChecklist
- [ ] Added a changelog entryAuthors