Throw BrowserSwitchException When Unable to Start Activity #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahkoop
commented
Dec 12, 2023
| activity.startActivity(launchUrlInBrowser); | ||
| try { | ||
| activity.startActivity(launchUrlInBrowser); | ||
| } catch (ActivityNotFoundException e) { |
There was a problem hiding this comment.
Opted for this approach rather than a check if able to perform intent to avoid any false negatives on devices having browsers.
There was a problem hiding this comment.
This is a good catch! I didn't understand at first. ActivityNotFoundException is a runtime exception so it isn't checked by the compiler. This will prevent apps from crashing.
sshropshire
approved these changes
Dec 12, 2023
jaxdesmarais
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ActivityNotFoundExceptionthat is thrown inBrowserSwitchClient#startwhen a browser app is not available, and throw aBrowserSwitchExceptionas defined by the method contractChecklist
Authors