Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

BUGFIX : include version into filename #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandredubois
Copy link

Using the -p:Version flag allow dotnet pack to add the specified version to be included into the package

@alexandredubois alexandredubois changed the title include version into filename BUGFIX : include version into filename Jul 9, 2021
@AraHaan
Copy link
Contributor

AraHaan commented Jul 15, 2021

Question does my fork at https://github.com/Elskom/publish-nuget/ fix this for you as well.

Note: With that fork you would need to use my other action as well which is Elskom/build-dotnet.

Copy link

@itniels itniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also solves issue #46 where VERSION_STATIC is unused for version.
I tested it by targeting the branch with this change like so: uses: alexandredubois/publish-nuget@Include-version-in-nupkgfile-name and it worked perfectly! 🙂

@lukebakken lukebakken self-assigned this May 7, 2022
@lukebakken lukebakken added this to the 2.6.0 milestone May 7, 2022
@lukebakken lukebakken removed their assignment Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants