Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search silently fails on about pages (such as about:addons) #373

Open
alphanumeric-characters-and-hyphens opened this issue Dec 18, 2021 · 2 comments
Labels
improvement This issue is an improvement to existing functionality.

Comments

@alphanumeric-characters-and-hyphens

I assume Mozilla prevents the addon from working on such pages, which is fine, but the tooltip still pops up as if it's searching normally and just can't find anything. I often forget this and erroneously conclude that the search terms don't appear on the page. It would be wonderful if the tooltip warned you or just didn't pop up on such pages.

@BrianHenryIE
Copy link

It fails on the moz-extension://... Find+ User Guide page which opens when the extension is installed in Firefox. Since it didn't work there, I assumed it wasn't working at all. At least, that page should have a notice at the top explaining the limitation.

@brandon1024
Copy link
Owner

There are a handful of pages this extension won't work on. about:addons is one of them, but the extension won't work on any browser-specific page (like the chrome web store, the page source tab, and likely a few others too). Chrome and Firefox disallow extensions in these contexts for security reasons.

We do have some special handling in https://github.com/brandon1024/find/blob/develop/popup/js/browser-action.js#L60 that will show a warning message if you're in the chrome web store pages, but I haven't implemented similar functionality for firefox (I don't use firefox). If any of you are interested in submitting a PR, I'd happily merge.

@brandon1024 brandon1024 added the improvement This issue is an improvement to existing functionality. label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue is an improvement to existing functionality.
Projects
None yet
Development

No branches or pull requests

3 participants