Don't pass around references to the scrach buffer #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- The scratch buffer is primarily used on cold paths (split reads during streaming or handling the last few tags in a block). Therefore, the value in reducing range checks, etc, by passing the reference around is minimal. This is mostly a holdover from when we pinned the reference, which was more important due to pinning cost. Modifications ------------- Stop passing the reference to the subroutines, just make a reference as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The scratch buffer is primarily used on cold paths (split reads during streaming or handling the last few tags in a block). Therefore, the value in reducing range checks, etc, by passing the reference around is minimal. This is mostly a holdover from when we pinned the reference, which was more important due to pinning cost.
Modifications
Stop passing the reference to the subroutines, just make a reference as needed.