Parallelize script #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
approved these changes
Jan 16, 2025
crawl.py
Outdated
Comment on lines
26
to
27
| parser.add_argument('-v', '--skip-vpn-check', action='store_true', dest='skip_vpn', help='Skip VPN check (default: required)') | ||
| parser.add_argument('-p', '--parallel', dest='parallel', action='store_true', help='Enable parallel crawling (default: sequential)') |
There was a problem hiding this comment.
(default: required) is somewhat confusing?
FWIW I think the default behavior is already clear enough without any callout here, since it's a binary toggle flag and doesn't take a value
|
FYI @mschfh you can use this for running in CI, crawling is a lot faster with this (need to pass in the flag). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ThreadPoolExecutorto have 10 worker threads. The script is overwhelmingly network-bound; we can easily parallelize the HTTP requests to the Cookiemonster API.Adds a new
--parallelargument to the script.