-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Decouple AdsService functionality from iOS BraveAds implementation #26451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
[puLL-Merge] - brave/brave-core@26451 DescriptionThis PR introduces significant changes to the Brave Ads implementation on iOS. The main change is the introduction of a new ChangesChanges
Possible Issues
Security HotspotsNo significant security hotspots were identified in this change. The refactoring primarily focuses on restructuring the code rather than introducing new security-sensitive operations. |
ProfileIOS* profile = [self getLastUsedProfile]; | ||
adsService = brave_ads::AdsServiceFactoryIOS::GetForBrowserState(profile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fyi, this will always be the regular profile (not private/OTR), which matches the current behaviour anyways, but just figured I'd point it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aseren could we please add a comment explaining this, along the lines of this will always be the regular profile (not private/OTR)
? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we add a CHECK instead of a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's actually a CHECK
under this line already :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an explanatory comment
Released in v1.75.8 |
This is a prerequisite for the Ads-Internals page task brave/brave-browser#40952, as we now need to access Ads Service from various parts of the Brave iOS codebase.
This is also the first step in Unification of Service Layer for iOS: brave/brave-browser#33868.
During next steps the current class AdsServiceImplIOS will be replaced by AdsService and AdsServiceImpl which will be directly re-used for iOS.
Resolves brave/brave-browser#42161
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Test Case 1
giraffe
requestSettings
->Shields & Privacy
->CLEAR PRIVATE DATA
->Brave Ads Data
Clear Data Now
buttonads/Ads.sqlite
are empty:Test Case 2