Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPN widget metrics #26748

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add VPN widget metrics #26748

merged 1 commit into from
Nov 28, 2024

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Nov 26, 2024

Resolves brave/brave-browser#42515

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Start with fresh profile, ensure no metrics exist.
  2. Click on the "free trial" button on the VPN widget. Ensure the widget usage metric has the value 0.
  3. Activate Brave VPN not using the widget, and then use the VPN connection toggle in the widget. Ensure the value is now 1.
  4. Hide the widget, ensure the hide widget metric has the value 1.

@DJAndries DJAndries requested a review from a team as a code owner November 26, 2024 04:52
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 26, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls also get an approve from VPN owners

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with one comment for fixing build failure on Android.

components/brave_vpn/browser/brave_vpn_metrics.cc Outdated Show resolved Hide resolved
@DJAndries DJAndries force-pushed the vpn-widget-p3a branch 2 times, most recently from 51fef07 to 307cb9f Compare November 27, 2024 03:05
@DJAndries DJAndries merged commit 8a6acfe into master Nov 28, 2024
17 checks passed
@DJAndries DJAndries deleted the vpn-widget-p3a branch November 28, 2024 05:24
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 28, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build needs-security-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VPN widget metrics
6 participants