Move scripttagextractor to AI #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for f in files: | ||
| main(f, args.suffix, args.add_suffix_to_original, args.dry_run) | ||
| with open(localdir + "/scripttagextractor.pkl", 'rb') as f: | ||
| data = pickle.load(f) |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Avoid using pickle, which is known to lead to code execution vulnerabilities. When unpickling, the serialized data could be manipulated to run arbitrary code. Instead, consider serializing the relevant data as JSON or a similar text-based serialization format.
Source: https://semgrep.dev/r/python.lang.security.deserialization.pickle.avoid-pickle
Cc @thypon @bcaller
diracdeltas
reviewed
May 13, 2024
|
|
||
| for f in files: | ||
| main(f, args.suffix, args.add_suffix_to_original, args.dry_run) | ||
| with open(localdir + "/scripttagextractor.pkl", 'rb') as f: |
There was a problem hiding this comment.
how did you create this file?
|
I don't get it. What on Earth is this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the script tag extractor to AI. AI production environments require
pickleto be fast enough.All the tests should pass, as they were passing before.
I feel the tradeoff is ok. /s