Glide library detection rule #715
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // ruleid: glide-library | ||
| import com.bumptech.glide.load.DataSource; | ||
|
|
||
| if (mBraveNewsController != null) { | ||
| mBraveNewsController.getImageData(adImageUrl, imageData -> { | ||
| if (imageData != null) { | ||
| Bitmap decodedByte = | ||
| BitmapFactory.decodeByteArray(imageData, 0, imageData.length); | ||
| // ruleid: glide-library | ||
| Glide.with(mActivity) | ||
|
There was a problem hiding this comment. reported by reviewdog 🐶 |
||
| .asBitmap() | ||
| .load(decodedByte) | ||
| .fitCenter() | ||
| .priority(Priority.IMMEDIATE) | ||
| .diskCacheStrategy(DiskCacheStrategy.ALL) | ||
| .into(new CustomTarget<Bitmap>() { | ||
| @Override | ||
| public void onResourceReady(@NonNull Bitmap resource, | ||
| @Nullable Transition<? super Bitmap> transition) { | ||
| imageView.setImageBitmap(resource); | ||
| } | ||
| @Override | ||
| public void onLoadCleared(@Nullable Drawable placeholder) {} | ||
| }); | ||
| imageView.setClipToOutline(true); | ||
| } | ||
| }); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| rules: | ||
| - id: glide-library | ||
| metadata: | ||
| author: Artem Chaikin | ||
| references: | ||
| - https://github.com/brave/reviews/issues/1391 | ||
| source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/glide-library.yaml | ||
| assignees: | | ||
| stoletheminerals | ||
| bridiver | ||
| message: "The Glide image loading library is not yet approved, new usages should not be implemented until the security team has given their approval." | ||
| languages: [java] | ||
| severity: WARNING | ||
| patterns: | ||
| - pattern-either: | ||
| - pattern: "import com.bumptech.glide" | ||
| - pattern: "Glide.with(...)" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] The Glide image loading library is not yet approved, new usages should not be implemented until the security team has given their approval.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/glide-library.yaml
Cc @stoletheminerals @bridiver