-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds docker-compose #31
base: staging
Are you sure you want to change the base?
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@AlanBreck May you add the advised docker-compose flags? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kim0 kindly added those flags. It appears that the comments didn't resolve themselves, though. @thypon, can you verify that everything looks good? |
Yes, the flags look fine. I can't remove the needs-security-review label myself. |
I could remove the label and resolved the bot conversations. |
Good call @kim0! It does in fact break. |
@kim0, would you mind taking a peak at this if/when you get a chance? Not high priority, but I'm not quite sure how to proceed. |
@AlanBreck Sure. Took a shot today, hit the below. How can I get past this
Also I might be missing .env files. |
@kim0, sorry, try this:
|
@AlanBreck spent some cycles on this. It seems to "start" correctly now. I'm able to hit the api endpoint correctly, however store/vite is issuing an error which is probably easy for you to fix. Might also be the branch being old, and needing a sync from
The main changes I just pushed are:
Please test and let me know how it goes! |
c2480e3
to
f91a403
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Just rebased to fix conflicts but still needs some attention from @AlanBreck. |
61736b7
to
eb0fdc1
Compare
This adds
docker-compose
for easier local development set up.Resolves https://github.com/brave/devops/issues/9555