Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename init() to connect() #119

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Rename init() to connect() #119

merged 6 commits into from
Apr 29, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Apr 29, 2024

As discussed in #114 (comment) , this PR renames init to connect.

@ok300 ok300 requested a review from dangeross April 29, 2024 11:44
@ok300
Copy link
Contributor Author

ok300 commented Apr 29, 2024

I've also shortened the commit ID when referencing a dependency, because the longer commit ID seems to be unreliable with GitHub CI: https://github.com/breez/breez-sdk-liquid/actions/runs/8877674677/job/24371730151

Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the RN example app also needs updating:

import { Network, getInfo, init } from "@breeztech/react-native-liquid-swap-sdk"

and
await init(mnemonic, undefined, Network.LIQUID)
addLine("init", null)

@ok300
Copy link
Contributor Author

ok300 commented Apr 29, 2024

Good catch, done.

@ok300 ok300 requested a review from dangeross April 29, 2024 12:36
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit 522bdae into main Apr 29, 2024
4 checks passed
@ok300 ok300 deleted the ok300-rename-init-to-connect branch April 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants