-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename init() to connect() #119
Conversation
I've also shortened the commit ID when referencing a dependency, because the longer commit ID seems to be unreliable with GitHub CI: https://github.com/breez/breez-sdk-liquid/actions/runs/8877674677/job/24371730151 |
Rename the manually coded init function to connect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the RN example app also needs updating:
import { Network, getInfo, init } from "@breeztech/react-native-liquid-swap-sdk" |
and
breez-sdk-liquid/lib/ls-sdk-react-native/example/App.js
Lines 46 to 47 in 021d28c
await init(mnemonic, undefined, Network.LIQUID) | |
addLine("init", null) |
Good catch, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed in #114 (comment) , this PR renames
init
toconnect
.