-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zero-amount Receive Chain Swap #538
Merged
+570
−59
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
89e20d4
Add zero-amount Receive Chain Swap
ok300 bedc05d
prep-receive-payment: Add min/max fields for zero-amount swaps
ok300 92c403b
prep-receive-payment: Add service feerate for zero-amount swaps
ok300 445418c
Merge branch 'main' into ok300-amountless-chain-swaps
ok300 c1a556b
Get and accept quote to advance Zero-Amount Chain Swaps
ok300 333c5c5
Fix tests
ok300 05483a5
Re-generate flutter bindings
ok300 322972f
Re-generate RN bindings
ok300 35cb343
Update swap payer_amount when we know the quote
ok300 f201d6c
Merge branch 'main' into ok300-amountless-chain-swaps
ok300 d3f4488
Rename receive_onchain arg
ok300 1e18406
Rename PrepareReceiveResponse fields
ok300 ab921c4
Fix cargo clippy
ok300 5a44caf
Improve error handling when accepting quote
ok300 c597ced
Update zero-amount payer/receiver values in DB
ok300 98864c7
Set min/max/feerate in prepare response for both LN and Chain swaps
ok300 a8efee5
Merge branch 'main' into ok300-amountless-chain-swaps
ok300 2bfd81c
Validate fees amountless swaps before accepting quote
ok300 842df7a
Fix CLI fee arg handling
ok300 183c828
Calculate, persist payer/receiver amounts when quote is accepted
ok300 618879d
Update log comment
ok300 e8ac979
Bump boltz-rust to latest trunk
ok300 addde46
PrepareReceiveResponse: rename service_feerate to swapper_feerate
ok300 4576ad9
Tweak amountless swap quote validation
ok300 542dec7
Add docs for swapper_feerate handling in total fee
ok300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we will need to document the fact that in amountless swap applications need to add the service fee on top of the fees_sat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 542dec7