Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time Sync: Integrate changes on the SDK #578

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

hydra-yse
Copy link
Member

Based on #555, #556, #568.
Closes #506.

lib/core/src/sdk.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse force-pushed the yse-rt-integrate branch 5 times, most recently from 84c9604 to 42856fc Compare November 28, 2024 00:43
@@ -76,6 +80,7 @@ impl Config {
network: LiquidNetwork::Testnet,
payment_timeout_sec: 15,
zero_conf_min_fee_rate_msat: DEFAULT_ZERO_CONF_MIN_FEE_RATE_TESTNET,
sync_service_url: BREEZ_SYNC_SERVICE_URL.to_string(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same service URL for mainnet/testnet, is this going to cause a conflict if using the same mnemonic for both? I imagine it will merge swap data from both together...

self.client.connect(self.remote_url.clone()).await?;

self.check_remote_change()?;
async fn run_event_loop(&self) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is a bit misleading, maybe push_pull()?

@hydra-yse hydra-yse force-pushed the yse-rt-run branch 2 times, most recently from 83cfeb6 to bcbc163 Compare December 5, 2024 01:39
@hydra-yse hydra-yse changed the base branch from yse-rt-run to rt-sync December 5, 2024 02:10
@hydra-yse hydra-yse force-pushed the yse-rt-integrate branch 2 times, most recently from 71f5ef0 to 01e67ee Compare December 5, 2024 05:00
fix: add formatting command to build

feat: add secondary trigger to sync

deps: add tonic tls-webpki-roots

feat: prevent double claiming on status stream handlers

fix: add tx commit to chain swap update (#588)

fix: ensure we pull records before prepare_send

fix: fmt and tests
@hydra-yse hydra-yse merged commit b0f1089 into rt-sync Dec 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants