Persist swapper fees for swaps #586
Conversation
lib/core/src/model.rs
Outdated
| @@ -631,6 +631,8 @@ pub(crate) struct ChainSwap { | |||
| pub(crate) payer_amount_sat: u64, | |||
| pub(crate) receiver_amount_sat: u64, | |||
| pub(crate) claim_fees_sat: u64, | |||
| pub(crate) swapper_service_feerate: f64, | |||
| pub(crate) swapper_server_fees_sat: u64, | |||
There was a problem hiding this comment.
Do you think it makes sense to persist the pair as json in one field instead of breaking it (the same way we do with the create swap response)? It also contains other useful information that may help us validate things in the future such as limits and we can use the pair object functions later to validate fees the same way we do on creating the swap.
| /// Service fees paid to the swapper service. This is only set for swaps (i.e. doesn't apply to | ||
| /// direct Liquid payments). | ||
| pub swapper_fees_sat: Option<u64>, | ||
|
|
There was a problem hiding this comment.
I'm wondering if the swapper_fees_sat should go into the PaymentDetails, as they do only apply to Lightning and Bitcoin payments?
There was a problem hiding this comment.
Too late 😅, sorry my fault
| let swapper_fees_sat = maybe_chain_swap_pair_fees | ||
| .map(|pair| pair.fees.percentage) | ||
| .map(|fr| ((fr / 100.0) * payer_amount_sat as f64).ceil() as u64) | ||
| .unwrap_or(0); |
There was a problem hiding this comment.
I wanted to question if the server fee for chain swaps should be considered as swapper fees, but I guess its part of the tx fee just like the claim fee
This PR stores the swapper service fees for each swap type.
The service fee is reflected in the
Paymentinswapper_fees_sat. ThePaymentalready contains the total fees infees_sat, so from these two values a user can find the total swap network fees (total - service fees).For chain swaps, this PR persists the service feerate instead of the service fee. In addition it also stores the server fees, which are a chain-swap-specific type of network fee (lockup tx fees paid by the server when locking up funds for the destination chain). These two new chain swap fields will later be used to validate the fees in Amountless Receive Chain Swaps.