Sync improvements #598
Merged
Sync improvements #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-sync-improvements
branch
from
94c8c76 to
35bf522
Compare
roeierez
requested changes
Dec 12, 2024
lib/core/src/sdk.rs
Outdated
| _ = cloned.sync().await; | ||
| } else { | ||
| // Partial sync of wallet txs | ||
| _ = cloned.sync_payments_with_chain_data(true).await; |
There was a problem hiding this comment.
This will not trigger sync event (UI won't refresh) perhaps we should pass the partial flag to sync and call sync?
There was a problem hiding this comment.
Updated to pass partial_sync through the sync fn, so the Synced event emits every ~10 seconds
dangeross
force-pushed
the
savage-sync-improvements
branch
from
35bf522 to
6eb23eb
Compare
roeierez
approved these changes
Dec 12, 2024
hydra-yse
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Full sync on new Bitcoin block * Track the last unconfirmed refund tx * Trigger synced event on partial sync
hydra-yse
pushed a commit
that referenced
this pull request
Dec 14, 2024
* Full sync on new Bitcoin block * Track the last unconfirmed refund tx * Trigger synced event on partial sync
hydra-yse
pushed a commit
that referenced
this pull request
Dec 24, 2024
* Full sync on new Bitcoin block * Track the last unconfirmed refund tx * Trigger synced event on partial sync
hydra-yse
added a commit
that referenced
this pull request
Dec 24, 2024
* feat(rt-sync): add persistency layer (#555) * feat(rt-sync): add pull and merge (#556) * feat(rt-sync): add push logic and run method (#568) * feat(rt-sync): integrate rt-sync with the sdk fix: add formatting command to build feat: add secondary trigger to sync deps: add tonic tls-webpki-roots feat: prevent double claiming on status stream handlers fix: add tx commit to chain swap update (#588) fix: ensure we pull records before prepare_send fix: fmt and tests * fix: set initial pulled state to `Recoverable` * feat(rt-sync): add `last_derivation_index` to sync service * Single chain source * Handle Recoverable state * fix(rt-sync): chain recovery integration (#590) Co-authored-by: yse <[email protected]> * feat(rt-sync): add `pair_fees_json` * fix(rt-sync): clean already persisted incoming records * feat: cache wallet info (#591) * log: add status-stream logging for non-local swaps * Sync improvements (#598) * Full sync on new Bitcoin block * Track the last unconfirmed refund tx * Trigger synced event on partial sync * fix: remove `REPLACE` clause from swap insert/update * fix(rt-sync): update chain swap payer/receiver amount (#604) * Fix syncing last derivation index * fix: update bindings and lockfile * remove logs * fix(rt-sync): avoid reuse of derivation index update logic (#608) * Add 5 index buffer to full scan * Fix storing claim_address (#609) * Filter incoming MRH txs by swap timestamp * fix liquid panding timestamp * persist tx data timestamp * Update unconfirmed transactions * feat: add API key (#618) * Use configured lazy connect channel in sync service * fix: set lower-case header (#624) * fix error message * Store & Sync LNURL info (#617) * Persist and decrypt LNURL info * Update Notification Plugin * Sync payment details * Update list payments to include chain swaps with only user lockup (#620) * Update payments query to include chain swaps without txs * Allow emitting a payment event without tx_id * fix: bindings --------- Co-authored-by: Ross Savage <[email protected]> Co-authored-by: Ross Savage <[email protected]> Co-authored-by: Roei Erez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: