Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support default external input parsers #614

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Support default external input parsers #614

merged 3 commits into from
Dec 20, 2024

Conversation

danielgranhao
Copy link
Contributor

Closes #599

This can be tried out using the CLI. To get a test Picknpay input, run:

curl -s -o /dev/null -D - 'https://api.circuit.cryptoconvert.co.za/test/qr.png?amountCents=100&completion=confirm' | grep x-mpm-code | sed 's/x-mpm-code: //'

@danielgranhao danielgranhao force-pushed the default-external-input-parsers branch from b1d5533 to 72a9aa6 Compare December 16, 2024 19:37
roeierez
roeierez requested changes Dec 16, 2024
View reviewed changes
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Show resolved Hide resolved
roeierez
roeierez approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dangeross
dangeross approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielgranhao danielgranhao merged commit b0b88b8 into main Dec 20, 2024
8 checks passed
@danielgranhao danielgranhao deleted the default-external-input-parsers branch December 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

@dangeross dangeross dangeross approved these changes

@hydra-yse hydra-yse Awaiting requested review from hydra-yse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default external input parsers/plugins
3 participants
@danielgranhao @dangeross @roeierez