Pre-check updated fields before committing outgoing sync #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
reviewed
Dec 22, 2024
dangeross
force-pushed
the
savage-updated-fields
branch
from
1359123 to
dea34b9
Compare
hydra-yse
force-pushed
the
savage-updated-fields
branch
from
dea34b9 to
125437b
Compare
roeierez
requested changes
Dec 24, 2024
roeierez
approved these changes
Dec 28, 2024
dangeross
commented
Dec 28, 2024
danielgranhao
approved these changes
Jan 1, 2025
hydra-yse
force-pushed
the
savage-updated-fields
branch
from
4fb0fc8 to
c0d5562
Compare
hydra-yse
force-pushed
the
savage-updated-fields
branch
from
c0d5562 to
3ea1590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pre-checks the updated swap against the existing swap, if some fields are updated then commit outgoing sync
(Draft while I can't test with rt-sync)