Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Use qrcode-rs instead of qr2term #88

Merged
merged 1 commit into from
Apr 16, 2024
Merged

CLI: Use qrcode-rs instead of qr2term #88

merged 1 commit into from
Apr 16, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Apr 15, 2024 •
edited
Loading

This PR replaces the qr2term dependency with qrcode-rs because the later is better maintained and has itself fewer dependencies:

@ok300 ok300 requested review from hydra-yse and dangeross April 15, 2024 19:04
dangeross
dangeross approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hydra-yse
hydra-yse approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit 5e190a9 into main Apr 16, 2024
2 checks passed
@ok300 ok300 deleted the ok300-cli-qr branch April 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydra-yse hydra-yse hydra-yse approved these changes

@dangeross dangeross dangeross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ok300 @dangeross @hydra-yse