Improve workingDir and disconnect handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-fix-config-disconnect
branch
from
c727b9d to
6b4b560
Compare
|
Wouldn't it be better to do this at SDK level, for example with breez/breez-sdk-greenlight#374 ? |
This is just a change to conform with how the SDK currently works, before it wasn't possible in RN to set the workingDir at all. |
dangeross
force-pushed
the
savage-fix-config-disconnect
branch
from
f47a493 to
c712812
Compare
dangeross
force-pushed
the
savage-fix-config-disconnect
branch
from
c712812 to
524d349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables different nodes to be run through RN (one at a time) by allowing the workingDir to be set as a subdirectory of the application directory and resetting the breezServices instance when disconnect is called.
Generated code breez/breez-sdk-greenlight#571