handle tu64 fields of any size #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tu64 is a truncated integer, with omitted leading zero bytes. This means a tu64 can be any length. Previously the `get_tu64` function could only handle tu64 fields with a length of 1, 2, 4 or 8. Now it can handle all lengths.
roeierez
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tu64 is a truncated integer, with omitted leading zero bytes. This means a tu64 can be any length. Previously the
get_tu64function could only handle tu64 fields with a length of 1, 2, 4 or 8. Now it can handle all lengths.Greenlight truncates the leading zero bytes here:
https://github.com/Blockstream/greenlight/blob/3a913fef893cc04d374c29853a45bb225349ea1b/libs/gl-plugin/src/tlv.rs#L146-L151
Fixes the error:
Got invalid amount of len 3 in htlc TLV: Unexpect TU64 length: 3