Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
master-sourcery
branch
2 times, most recently
from
e5ff2ce to
d020a29
Compare
sourcery-ai
bot
changed the title
sourcery-ai
bot
force-pushed
the
master-sourcery
branch
3 times, most recently
from
112b4ed to
9e56be5
Compare
sourcery-ai
bot
force-pushed
the
master-sourcery
branch
from
9e56be5 to
a17e0cd
Compare
sourcery-ai
bot
force-pushed
the
master-sourcery
branch
from
a17e0cd to
92a5859
Compare
| @@ -50,10 +50,7 @@ | |||
| DISK_FOUR_COUNTS = np.zeros([HEIGHT, WIDTH], int) | |||
| for row in range(HEIGHT): | |||
| for column in range(WIDTH): | |||
There was a problem hiding this comment.
Lines 53-56 refactored with the following changes:
- Convert for loop into list comprehension
| @@ -106,10 +106,10 @@ def variables(self): | |||
| self.scope + '/') | |||
|
|
|||
| def assign(self, other): | |||
There was a problem hiding this comment.
Function BaseNetwork.assign refactored with the following changes:
- Convert for loop into list comprehension
- Inline variable that is only used once
| @@ -141,8 +141,7 @@ def train_games(self, opponent, games): | |||
|
|
|||
| def process_results(self, opponent, games, step, summary): | |||
| win_rate = np.mean([game.policy_player_score for game in games]) | |||
There was a problem hiding this comment.
Function PolicyTraining.process_results refactored with the following changes:
- Replace unneeded comprehension with generator
| @@ -263,10 +262,7 @@ def move(self, move, policy_player_turn=False): | |||
| self.positions.append(self.position) | |||
| if self.position.gameover(): | |||
| self.result = self.position.result | |||
There was a problem hiding this comment.
Function Game.move refactored with the following changes:
- Replace if statement with if expression
| @@ -10,7 +10,7 @@ def find_previous_run(dir): | |||
| if os.path.isdir(dir): | |||
| runs = [child[4:] for child in os.listdir(dir) if child[:4] == 'run_'] | |||
| if runs: | |||
There was a problem hiding this comment.
Function run_directory.find_previous_run refactored with the following changes:
- Replace unneeded comprehension with generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
To manually merge these changes, make sure you're on the
masterbranch, then run:See our documentation for configuring or disabling Sourcery.